]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mmc: rtsx_pci_sdmmc: fix incorrect last byte in R2 response
authorRoger Tseng <rogerable@realtek.com>
Fri, 15 Aug 2014 06:06:00 +0000 (14:06 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 Nov 2014 18:10:23 +0000 (10:10 -0800)
commitd9904f1e9451607fb915057bb40253ee6e6a7c30
treef7a262b56772c3610acbf6dd7e8cd48e5dbdbc38
parent5651243b41871c4dc2e2d47df1f990c9fcae767f
mmc: rtsx_pci_sdmmc: fix incorrect last byte in R2 response

commit d1419d50c1bf711e9fd27b516a739c86b23f7cf9 upstream.

Current code erroneously fill the last byte of R2 response with an undefined
value. In addition, the controller actually 'offloads' the last byte
(CRC7, end bit) while receiving R2 response and thus it's impossible to get the
actual value. This could cause mmc stack to obtain inconsistent CID from the
same card after resume and misidentify it as a different card.

Fix by assigning dummy CRC and end bit: {7'b0, 1} = 0x1 to the last byte of R2.

Fixes: ff984e57d36e ("mmc: Add realtek pcie sdmmc host driver")
Signed-off-by: Roger Tseng <rogerable@realtek.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mmc/host/rtsx_pci_sdmmc.c