]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
octeontx2: Fix otx2_dma_map_page() error return code
authorThomas Fourier <fourier.thomas@gmail.com>
Wed, 14 Jan 2026 12:31:06 +0000 (13:31 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 17 Jan 2026 23:40:06 +0000 (15:40 -0800)
commitd998b0e5afffa90d0f03770bad31083767079858
tree288545b0fd94e26b21fe4b7add000fb7a108c858
parenta80c9d945aef55b23b54838334345f20251dad83
octeontx2: Fix otx2_dma_map_page() error return code

0 is a valid DMA address [1] so using it as the error value can lead to
errors.  The error value of dma_map_XXX() functions is DMA_MAPPING_ERROR
which is ~0.  The callers of otx2_dma_map_page() use dma_mapping_error()
to test the return value of otx2_dma_map_page(). This means that they
would not detect an error in otx2_dma_map_page().

Make otx2_dma_map_page() return the raw value of dma_map_page_attrs().

[1] https://lore.kernel.org/all/f977f68b-cec5-4ab7-b4bd-2cf6aca46267@intel.com

Fixes: caa2da34fd25 ("octeontx2-pf: Initialize and config queues")
Cc: <stable@vger.kernel.org>
Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com>
Link: https://patch.msgid.link/20260114123107.42387-2-fourier.thomas@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.h