]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Add VIR_DIV_UP to divide memory or storage request sizes with round up
authorMatthias Bolte <matthias.bolte@googlemail.com>
Fri, 28 Jan 2011 21:03:24 +0000 (22:03 +0100)
committerMatthias Bolte <matthias.bolte@googlemail.com>
Fri, 28 Jan 2011 23:42:10 +0000 (00:42 +0100)
commitd9ad8ac392635afc4ff9aaa5a15ebf48e96ac34e
tree9d8a7de1ccf5cab5cd6880f4e534d481621e8518
parent6fc1159d9499aae870cf285203465555dae6ce42
Add VIR_DIV_UP to divide memory or storage request sizes with round up

Use it in all places where a memory or storage request size is converted
to a larger granularity. This avoids requesting too small memory or storage
sizes that could result from the truncation done by a simple division.

This extends the round up fix in 6002e0406c338668ea0ecbfeb6c1ef20a8b67efe
to the whole codebase.

Instead of reporting errors for odd values in the VMX code round them up.

Update the QEMU Argv tests accordingly as the original memory size 219200
isn't a even multiple of 1024 and is rounded up to 215 megabyte now. Change
it to 219100 and 219136. Use two different values intentionally to make
sure that rounding up works.

Update virsh.pod accordingly, as rounding down and rejecting are replaced
by rounding up.
141 files changed:
src/esx/esx_driver.c
src/esx/esx_storage_driver.c
src/internal.h
src/opennebula/one_conf.c
src/qemu/qemu_command.c
src/qemu/qemu_monitor_text.c
src/storage/storage_backend.c
src/storage/storage_backend_logical.c
src/vbox/vbox_tmpl.c
src/vmx/vmx.c
src/xen/xend_internal.c
src/xen/xm_internal.c
tests/qemuxml2argvdata/qemuxml2argv-balloon-device-auto.xml
tests/qemuxml2argvdata/qemuxml2argv-balloon-device.xml
tests/qemuxml2argvdata/qemuxml2argv-boot-cdrom.xml
tests/qemuxml2argvdata/qemuxml2argv-boot-floppy.xml
tests/qemuxml2argvdata/qemuxml2argv-boot-menu-disable.xml
tests/qemuxml2argvdata/qemuxml2argv-boot-multi.xml
tests/qemuxml2argvdata/qemuxml2argv-boot-network.xml
tests/qemuxml2argvdata/qemuxml2argv-boot-order.xml
tests/qemuxml2argvdata/qemuxml2argv-bootloader.xml
tests/qemuxml2argvdata/qemuxml2argv-channel-guestfwd.xml
tests/qemuxml2argvdata/qemuxml2argv-channel-virtio-auto.xml
tests/qemuxml2argvdata/qemuxml2argv-channel-virtio.xml
tests/qemuxml2argvdata/qemuxml2argv-clock-france.xml
tests/qemuxml2argvdata/qemuxml2argv-clock-localtime.xml
tests/qemuxml2argvdata/qemuxml2argv-clock-utc.xml
tests/qemuxml2argvdata/qemuxml2argv-clock-variable.xml
tests/qemuxml2argvdata/qemuxml2argv-console-compat-auto.xml
tests/qemuxml2argvdata/qemuxml2argv-console-compat-chardev.xml
tests/qemuxml2argvdata/qemuxml2argv-console-compat.xml
tests/qemuxml2argvdata/qemuxml2argv-console-virtio.xml
tests/qemuxml2argvdata/qemuxml2argv-cpu-exact1.xml
tests/qemuxml2argvdata/qemuxml2argv-cpu-exact2.xml
tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum1.xml
tests/qemuxml2argvdata/qemuxml2argv-cpu-minimum2.xml
tests/qemuxml2argvdata/qemuxml2argv-cpu-strict1.xml
tests/qemuxml2argvdata/qemuxml2argv-cpu-topology1.xml
tests/qemuxml2argvdata/qemuxml2argv-cpu-topology2.xml
tests/qemuxml2argvdata/qemuxml2argv-cpu-topology3.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-aio.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom-empty.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-cdrom.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-cdrom.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-boot-disk.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-none.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wb.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v1-wt.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-none.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wb.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-cache-v2-wt.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-enospace.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-error-policy-stop.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fat.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-fmt-qcow.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-nbd.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-rbd.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-sheepdog.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-disk.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-readonly-no-device.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-shared.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-floppy.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-many.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-device-auto.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-device.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-usb-device.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-usb.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-virtio.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-xenvbd.xml
tests/qemuxml2argvdata/qemuxml2argv-floppy-drive-fat.xml
tests/qemuxml2argvdata/qemuxml2argv-fs9p.xml
tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl-fullscreen.xml
tests/qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml
tests/qemuxml2argvdata/qemuxml2argv-graphics-spice.xml
tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-sasl.xml
tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-socket.xml
tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc-tls.xml
tests/qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-pci-address-device.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-pci-address.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address-device.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-usb-address.xml
tests/qemuxml2argvdata/qemuxml2argv-hugepages.xml
tests/qemuxml2argvdata/qemuxml2argv-input-usbmouse.xml
tests/qemuxml2argvdata/qemuxml2argv-input-usbtablet.xml
tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml
tests/qemuxml2argvdata/qemuxml2argv-machine-aliases1.xml
tests/qemuxml2argvdata/qemuxml2argv-machine-aliases2.xml
tests/qemuxml2argvdata/qemuxml2argv-memtune.xml
tests/qemuxml2argvdata/qemuxml2argv-migrate.xml
tests/qemuxml2argvdata/qemuxml2argv-minimal.xml
tests/qemuxml2argvdata/qemuxml2argv-misc-acpi.xml
tests/qemuxml2argvdata/qemuxml2argv-misc-no-reboot.xml
tests/qemuxml2argvdata/qemuxml2argv-misc-uuid.xml
tests/qemuxml2argvdata/qemuxml2argv-net-eth-ifname.xml
tests/qemuxml2argvdata/qemuxml2argv-net-eth-names.xml
tests/qemuxml2argvdata/qemuxml2argv-net-eth.xml
tests/qemuxml2argvdata/qemuxml2argv-net-user.xml
tests/qemuxml2argvdata/qemuxml2argv-net-virtio-device.xml
tests/qemuxml2argvdata/qemuxml2argv-net-virtio-netdev.xml
tests/qemuxml2argvdata/qemuxml2argv-net-virtio.xml
tests/qemuxml2argvdata/qemuxml2argv-nographics-vga.xml
tests/qemuxml2argvdata/qemuxml2argv-nographics.xml
tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp-chardev.xml
tests/qemuxml2argvdata/qemuxml2argv-parallel-tcp.xml
tests/qemuxml2argvdata/qemuxml2argv-qemu-ns-no-env.xml
tests/qemuxml2argvdata/qemuxml2argv-qemu-ns.xml
tests/qemuxml2argvdata/qemuxml2argv-restore-v1.xml
tests/qemuxml2argvdata/qemuxml2argv-restore-v2-fd.xml
tests/qemuxml2argvdata/qemuxml2argv-restore-v2.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-dev-chardev.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-dev.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-file-chardev.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-file.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-many-chardev.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-many.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-pty-chardev.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-pty.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-chardev.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet-chardev.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-tcp-telnet.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-tcp.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-udp-chardev.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-udp.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-unix-chardev.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-unix.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-vc-chardev.xml
tests/qemuxml2argvdata/qemuxml2argv-serial-vc.xml
tests/qemuxml2argvdata/qemuxml2argv-smbios.xml
tests/qemuxml2argvdata/qemuxml2argv-smp.xml
tests/qemuxml2argvdata/qemuxml2argv-sound-device.xml
tests/qemuxml2argvdata/qemuxml2argv-sound.xml
tests/qemuxml2argvdata/qemuxml2argv-watchdog-device.xml
tests/qemuxml2argvdata/qemuxml2argv-watchdog-dump.xml
tests/qemuxml2argvdata/qemuxml2argv-watchdog.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-balloon-device-auto.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-channel-virtio-auto.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-console-compat-auto.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-console-virtio.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-scsi-device-auto.xml
tools/virsh.pod