]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
s390/ctcm: Fix double-kfree
authorAleksei Nikiforov <aleksei.nikiforov@linux.ibm.com>
Wed, 12 Nov 2025 18:27:24 +0000 (19:27 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 18 Nov 2025 00:58:25 +0000 (16:58 -0800)
commitda02a1824884d6c84c5e5b5ac373b0c9e3288ec2
treeb434f4e43c6b9d5d749773398fef36d20444d0a7
parent5442a9da69789741bfda39f34ee7f69552bf0c56
s390/ctcm: Fix double-kfree

The function 'mpc_rcvd_sweep_req(mpcginfo)' is called conditionally
from function 'ctcmpc_unpack_skb'. It frees passed mpcginfo.
After that a call to function 'kfree' in function 'ctcmpc_unpack_skb'
frees it again.

Remove 'kfree' call in function 'mpc_rcvd_sweep_req(mpcginfo)'.

Bug detected by the clang static analyzer.

Fixes: 0c0b20587b9f25a2 ("s390/ctcm: fix potential memory leak")
Reviewed-by: Aswin Karuvally <aswin@linux.ibm.com>
Signed-off-by: Aleksei Nikiforov <aleksei.nikiforov@linux.ibm.com>
Signed-off-by: Aswin Karuvally <aswin@linux.ibm.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251112182724.1109474-1-aswin@linux.ibm.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/s390/net/ctcm_mpc.c