]> git.ipfire.org Git - thirdparty/libvirt.git/commit
qemu_command.c: move DISK_BUS_SATA validation to qemu_validate.c
authorDaniel Henrique Barboza <danielhb413@gmail.com>
Thu, 8 Oct 2020 18:26:20 +0000 (15:26 -0300)
committerDaniel Henrique Barboza <danielhb413@gmail.com>
Thu, 15 Oct 2020 12:55:37 +0000 (09:55 -0300)
commitda1748cab179ecb542dd6fc210ae23602c4ec80c
tree95648fadc79ec56a6a5a85b1763ffb708dc9a283
parentcd976920001737ef779dd09cc2f410e81c237841
qemu_command.c: move DISK_BUS_SATA validation to qemu_validate.c

A few tweaks were made during the move:

- the error messages were changed to mention 'sata controller'
instead of 'ide controller';

- a check for address type 'drive' was added like it is done
with other bus types. The error message of qemuxml2argdata was
updated to reflect that now, instead of erroring it out from the
common code in virDomainDiskDefValidate(), we're failing earlier
with a different error message.

Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/qemu/qemu_command.c
src/qemu/qemu_validate.c
tests/qemuxml2argvdata/disk-sata-incompatible-address.err