]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
scsi: Revert "scsi: sd: Do not repeat the starting disk message"
authorJohan Hovold <johan+linaro@kernel.org>
Tue, 16 Jul 2024 16:11:01 +0000 (18:11 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 23 Jul 2024 00:30:13 +0000 (20:30 -0400)
commitda3e19ef0b3de0aa4b25595bdc214c02a04f19b8
treed21ae5cb509de74256a36b6286c262d69826ad73
parent3911af778f208e5f49d43ce739332b91e26bc48e
scsi: Revert "scsi: sd: Do not repeat the starting disk message"

This reverts commit 7a6bbc2829d4ab592c7e440a6f6f5deb3cd95db4.

The offending commit tried to suppress a double "Starting disk" message for
some drivers, but instead started spamming the log with bogus messages
every five seconds:

[  311.798956] sd 0:0:0:0: [sda] Starting disk
[  316.919103] sd 0:0:0:0: [sda] Starting disk
[  322.040775] sd 0:0:0:0: [sda] Starting disk
[  327.161140] sd 0:0:0:0: [sda] Starting disk
[  332.281352] sd 0:0:0:0: [sda] Starting disk
[  337.401878] sd 0:0:0:0: [sda] Starting disk
[  342.521527] sd 0:0:0:0: [sda] Starting disk
[  345.850401] sd 0:0:0:0: [sda] Starting disk
[  350.967132] sd 0:0:0:0: [sda] Starting disk
[  356.090454] sd 0:0:0:0: [sda] Starting disk
...

on machines that do not actually stop the disk on runtime suspend (e.g.
the Qualcomm sc8280xp CRD with UFS).

Let's just revert for now to address the regression.

Fixes: 7a6bbc2829d4 ("scsi: sd: Do not repeat the starting disk message")
Cc: stable@vger.kernel.org
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20240716161101.30692-1-johan+linaro@kernel.org
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/sd.c