]> git.ipfire.org Git - thirdparty/libvirt.git/commit
tests: fix domaincapstest linking for libxl
authorRoman Bogorodskiy <bogorodskiy@gmail.com>
Sun, 14 Aug 2016 23:18:35 +0000 (02:18 +0300)
committerRoman Bogorodskiy <bogorodskiy@gmail.com>
Tue, 16 Aug 2016 00:12:05 +0000 (03:12 +0300)
commitda5dfd0e06cac740f746bcc7c839f839c4d64c30
tree2541c57f57c255dbc726bc96eb5626a7e4c50d01
parentcaaa1bd357a99ad9bffe96d8c7b397821e83ad85
tests: fix domaincapstest linking for libxl

Commit 11567cf added some libxl tests into domaincapstest and
added libvirt_driver_libxl_impl.la to domaincapstest_LDADD.

This causes link fail on systems without GNU regex implementation:

gmake[2]: Entering directory '/usr/home/novel/code/libvirt/tests'
  CCLD     domaincapstest
  ../src/.libs/libvirt_driver_libxl_impl.a(libvirt_driver_libxl_impl_la-libxl_capabilities.o):
  In function `libxlMakeCapabilities':
  libxl/libxl_capabilities.c:(.text+0x6b2): undefined reference to
  `rpl_regcomp'
  libxl/libxl_capabilities.c:(.text+0x6d0): undefined reference to
  `rpl_regerror'
  libxl/libxl_capabilities.c:(.text+0x803): undefined reference to
  `rpl_regexec'
  libxl/libxl_capabilities.c:(.text+0xa58): undefined reference to
  `rpl_regfree'
  clang-3.8: error: linker command failed with exit code 1 (use -v to
  see invocation)

This happens because on these system it tries to use gnulib's builtin
regex implementation, but doesn't link to gnulib.

Fix by adding $(GNULIB_LIBS) along with libvirt_driver_libxl_impl.la to
domaincapstest_LDADD.
tests/Makefile.am