]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix out-of-bounds access in autoprewarm worker
authorTomas Vondra <tomas.vondra@postgresql.org>
Fri, 26 Jun 2026 17:34:14 +0000 (19:34 +0200)
committerTomas Vondra <tomas.vondra@postgresql.org>
Fri, 26 Jun 2026 17:47:36 +0000 (19:47 +0200)
commitdac36601fd774a00b3b7390a656a689e2881bcf4
tree970b49429e718fd7981acac282300394370141af
parented9ec3abb601bbe6a22363ca5ac80959de8c14ef
Fix out-of-bounds access in autoprewarm worker

The read stream callback apw_read_stream_next_block() advances p->pos
through the block_info array. When processing the last block, it
increments p->pos to prewarm_stop_idx before returning. The callback
itself is safe because it checks bounds before accessing the array.

However, the caller assigned blk from block_info[i] at the end of the
loop body, before the loop condition was re-evaluated. When i equaled
prewarm_stop_idx, this accessed memory beyond the allocated DSM segment,
causing a segfault.

Restructure the loop to check bounds at the top and assign blk at the
beginning of the loop body, where it is always safe. This avoids the
need for an explicit bounds check at the end.

Backpatch to 18, where the bug was introduced by commit 6acab8bdbcda.

Author: Matheus Alcantara <mths.dev@pm.me>
Reported-by: Glauber Batista <glauberrbatista@gmail.com>
Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>
Reviewed-by: Tomas Vondra <tomas@vondra.me>
Backpatch-through: 18
Discussion: https://www.postgresql.org/message-id/CAO%2B_mTQgQyTYwDh%3DU8iTnsDmOGyWsZJjUV31SmEYwmw6_xY6Bw%40mail.gmail.com
contrib/pg_prewarm/autoprewarm.c