]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
regmap: dev_get_regmap_match(): fix string comparison
authorMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 3 Jul 2020 10:33:15 +0000 (12:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 31 Jul 2020 14:43:13 +0000 (16:43 +0200)
commitdb18027fbbe19c38c012aafa971a94f1e51b3771
tree75f95f1c7bc86c5bbf8fc77be887678fd1b0d789
parentcdde225d8db6fa51e33f6171faba9ed5b48162f8
regmap: dev_get_regmap_match(): fix string comparison

[ Upstream commit e84861fec32dee8a2e62bbaa52cded6b05a2a456 ]

This function is used by dev_get_regmap() to retrieve a regmap for the
specified device. If the device has more than one regmap, the name parameter
can be used to specify one.

The code here uses a pointer comparison to check for equal strings. This
however will probably always fail, as the regmap->name is allocated via
kstrdup_const() from the regmap's config->name.

Fix this by using strcmp() instead.

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://lore.kernel.org/r/20200703103315.267996-1-mkl@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/base/regmap/regmap.c