]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ethernet: fix potential use-after-free in ec_bhf_remove
authorPavel Skripkin <paskripkin@gmail.com>
Fri, 18 Jun 2021 13:49:02 +0000 (16:49 +0300)
committerSasha Levin <sashal@kernel.org>
Wed, 30 Jun 2021 12:49:34 +0000 (08:49 -0400)
commitdb2bc3cfd2bc01621014d4f17cdfc74611f339c8
tree0aec64ee8445d348573ae33a338088660d6b6a9c
parentf12554b0ff639e74612cc01b3b4a049e098d2d65
net: ethernet: fix potential use-after-free in ec_bhf_remove

[ Upstream commit 9cca0c2d70149160407bda9a9446ce0c29b6e6c6 ]

static void ec_bhf_remove(struct pci_dev *dev)
{
...
struct ec_bhf_priv *priv = netdev_priv(net_dev);

unregister_netdev(net_dev);
free_netdev(net_dev);

pci_iounmap(dev, priv->dma_io);
pci_iounmap(dev, priv->io);
...
}

priv is netdev private data, but it is used
after free_netdev(). It can cause use-after-free when accessing priv
pointer. So, fix it by moving free_netdev() after pci_iounmap()
calls.

Fixes: 6af55ff52b02 ("Driver for Beckhoff CX5020 EtherCAT master module.")
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/ec_bhf.c