]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: uvcvideo: Fix deadlock during uvc_probe
authorRicardo Ribalda <ribalda@chromium.org>
Tue, 22 Oct 2024 08:30:30 +0000 (08:30 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 8 Feb 2025 09:02:01 +0000 (10:02 +0100)
commitdb577ededf3a18b39567fc1a6209f12a0c4a3c52
tree0394b7b463fd6c36c10ffbfc7b3587f6c355d1da
parentd7260d595bd49a5c37eeb464ba26c0eb4f6869f2
media: uvcvideo: Fix deadlock during uvc_probe

[ Upstream commit a67f75c2b5ecf534eab416ce16c11fe780c4f8f6 ]

If uvc_probe() fails, it can end up calling uvc_status_unregister() before
uvc_status_init() is called.

Fix this by checking if dev->status is NULL or not in
uvc_status_unregister().

Reported-by: syzbot+9446d5e0d25571e6a212@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/linux-media/20241020160249.GD7770@pendragon.ideasonboard.com/T/#m506744621d72a2ace5dd2ab64055be9898112dbd
Fixes: c5fe3ed618f9 ("media: uvcvideo: Avoid race condition during unregister")
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Link: https://lore.kernel.org/r/20241022-race-unreg-v1-1-2212f364d9de@chromium.org
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/usb/uvc/uvc_status.c