]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Add complete coverage and fix lower() for MySQL 88718 workaround
authorMike Bayer <mike_mp@zzzcomputing.com>
Mon, 11 Feb 2019 14:07:03 +0000 (09:07 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Mon, 11 Feb 2019 14:12:37 +0000 (09:12 -0500)
commitdb589a98b2213ec1423c98c9c152d2ba2f7efe83
treeee9f2ba985c3ea54d0fd8f91727a6fa271e76192
parent9ca2c2d254dc6a0891e66910b640c97e357ae109
Add complete coverage and fix lower() for MySQL 88718 workaround

Fixed a second regression caused by :ticket:`4344` (the first was
:ticket:`4361`), which works around MySQL issue 88718, where the lower
casing function used was not correct for Python 2 with OSX/Windows casing
conventions, which would then raise ``TypeError``.  Full coverage has been
added to this logic so that every codepath is exercised in a mock style for
all three casing conventions on all versions of Python. MySQL 8.0 has
meanwhile fixed issue 88718 so the workaround is only applies to a
particular span of MySQL 8.0 versions.

Fixes: #4492
Change-Id: I14e7237e0be4a9c21c58c921066304ae99ac4dc6
(cherry picked from commit 49197c7b36573d91b015019d4635071f9da1c216)
doc/build/changelog/unreleased_12/4492.rst [new file with mode: 0644]
lib/sqlalchemy/dialects/mysql/base.py
test/dialect/mysql/test_reflection.py