]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
block, bfq: get a ref to a group when adding it to a service tree
authorPaolo Valente <paolo.valente@linaro.org>
Mon, 3 Feb 2020 10:40:59 +0000 (11:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Mar 2020 06:18:22 +0000 (07:18 +0100)
commitdb5f1fc99c3ea3f1248cedc47c77fe650d48e0b8
tree924578f61cfcd6b117fbe756fa371577376a23d1
parent21b61983da1c701133112d17f18782b129cdfc84
block, bfq: get a ref to a group when adding it to a service tree

[ Upstream commit db37a34c563bf4692b36990ae89005c031385e52 ]

BFQ schedules generic entities, which may represent either bfq_queues
or groups of bfq_queues. When an entity is inserted into a service
tree, a reference must be taken, to make sure that the entity does not
disappear while still referred in the tree. Unfortunately, such a
reference is mistakenly taken only if the entity represents a
bfq_queue. This commit takes a reference also in case the entity
represents a group.

Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
Tested-by: Chris Evich <cevich@redhat.com>
Signed-off-by: Paolo Valente <paolo.valente@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
block/bfq-cgroup.c
block/bfq-iosched.h
block/bfq-wf2q.c