]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: dwc3: core: fix order of PM runtime calls
authorFelipe Balbi <balbi@ti.com>
Tue, 2 Sep 2014 19:57:20 +0000 (14:57 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 5 Oct 2014 20:40:59 +0000 (13:40 -0700)
commitdb60b9bce86837ff59d4a4acc5b2b1f851323588
tree926860adf5b60735ac29a2e5fbae9449a8b316eb
parent6bd8ad714f653f11d4483df33a14bab4a92d46fc
usb: dwc3: core: fix order of PM runtime calls

commit fed33afce0eda44a46ae24d93aec1b5198c0bac4 upstream.

Currently, we disable pm_runtime before all register
accesses are done, this is dangerous and might lead
to abort exceptions due to the driver trying to access
a register which is clocked by a clock which was long
gated.

Fix that by moving pm_runtime_put_sync() and pm_runtime_disable()
as the last thing we do before returning from our ->remove()
method.

Fixes: 72246da (usb: Introduce DesignWare USB3 DRD Driver)
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/core.c