]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: sonic: return NETDEV_TX_OK if failed to map buffer
authorMao Wenan <maowenan@huawei.com>
Thu, 5 Sep 2019 01:57:12 +0000 (09:57 +0800)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 28 Apr 2020 18:03:33 +0000 (19:03 +0100)
commitdb6c908c9e2974c87688d3165c157b0e59c8d532
tree0e7791b584ce5ac647793949b704e1b02ae47c3b
parent10912babe0dff14eea532492a6b9c55f1471fd75
net: sonic: return NETDEV_TX_OK if failed to map buffer

commit 6e1cdedcf0362fed3aedfe051d46bd7ee2a85fe1 upstream.

NETDEV_TX_BUSY really should only be used by drivers that call
netif_tx_stop_queue() at the wrong moment. If dma_map_single() is
failed to map tx DMA buffer, it might trigger an infinite loop.
This patch use NETDEV_TX_OK instead of NETDEV_TX_BUSY, and change
printk to pr_err_ratelimited.

Fixes: d9fb9f384292 ("*sonic/natsemi/ns83829: Move the National Semi-conductor drivers")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/net/ethernet/natsemi/sonic.c