]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
vmxnet3: prevent building with 64K pages
authorArnd Bergmann <arnd@arndb.de>
Fri, 17 Feb 2017 15:08:30 +0000 (16:08 +0100)
committerSasha Levin <alexander.levin@microsoft.com>
Sun, 4 Mar 2018 15:28:28 +0000 (10:28 -0500)
commitdbe3c61245bdf755c644a49111a8924c6c207a82
treead3b58b139a743350babcb70739731c856abcb42
parent63408ea91c2c84ad42cb0ef3ff35280ebef31d0d
vmxnet3: prevent building with 64K pages

[ Upstream commit fbdf0e28d061708cf18ba0f8e0db5360dc9a15b9 ]

I got a warning about broken code on ARM64 with 64K pages:

drivers/net/vmxnet3/vmxnet3_drv.c: In function 'vmxnet3_rq_init':
drivers/net/vmxnet3/vmxnet3_drv.c:1679:29: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
    rq->buf_info[0][i].len = PAGE_SIZE;

'len' here is a 16-bit integer, so this clearly won't work. I don't think
this driver is used much on anything other than x86, so there is no need
to fix this properly and we can work around it with a Kconfig dependency
to forbid known-broken configurations. qemu in theory supports it on
other architectures too, but presumably only for compatibility with x86
guests that also run on vmware.

CONFIG_PAGE_SIZE_64KB is used on hexagon, mips, sh and tile, the other
symbols are architecture-specific names for the same thing.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/net/Kconfig