]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
dccp: fix out of bound access in dccp_v4_err()
authorEric Dumazet <edumazet@google.com>
Thu, 3 Nov 2016 02:00:40 +0000 (19:00 -0700)
committerJiri Slaby <jslaby@suse.cz>
Mon, 28 Nov 2016 21:22:36 +0000 (22:22 +0100)
commitdbf1719c65fb0368a94d15767c669e47e295a073
tree83372598ccad81ac26c36af71cdf0b981ead84d4
parent730082f962fbb21146e974c713f536d7000b5a79
dccp: fix out of bound access in dccp_v4_err()

[ Upstream commit 6706a97fec963d6cb3f7fc2978ec1427b4651214 ]

dccp_v4_err() does not use pskb_may_pull() and might access garbage.

We only need 4 bytes at the beginning of the DCCP header, like TCP,
so the 8 bytes pulled in icmp_socket_deliver() are more than enough.

This patch might allow to process more ICMP messages, as some routers
are still limiting the size of reflected bytes to 28 (RFC 792), instead
of extended lengths (RFC 1812 4.3.2.3)

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
net/dccp/ipv4.c