]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
NFSD: Mark filecache "down" if init fails
authorChuck Lever <chuck.lever@oracle.com>
Sat, 21 Sep 2024 18:25:37 +0000 (14:25 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 23 Sep 2024 14:37:20 +0000 (10:37 -0400)
commitdc0d0f885aa422f621bc1c2124133eff566b0bc8
tree65e34a41b553dc42b1ff97862fd41684d14c21d5
parent509abfc7a0ba66afa648e8216306acdc55ec54ed
NFSD: Mark filecache "down" if init fails

NeilBrown says:
> The handling of NFSD_FILE_CACHE_UP is strange.  nfsd_file_cache_init()
> sets it, but doesn't clear it on failure.  So if nfsd_file_cache_init()
> fails for some reason, nfsd_file_cache_shutdown() would still try to
> clean up if it was called.

Reported-by: NeilBrown <neilb@suse.de>
Fixes: c7b824c3d06c ("NFSD: Replace the "init once" mechanism")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/filecache.c