]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
can: kvaser_usb: Fix comparison bug in kvaser_usb_read_bulk_callback()
authorJimmy Assarsson <jimmyassarsson@gmail.com>
Tue, 21 Nov 2017 07:22:27 +0000 (08:22 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 16 Dec 2017 09:32:25 +0000 (10:32 +0100)
commitdc16a4dee968e69c418b9d5d3232829553d32177
tree2e01d7d4d6f3946d68e5aef63958718984299280
parent70d9dccf50152b0d7bfb2697d8c51e9fab9f782c
can: kvaser_usb: Fix comparison bug in kvaser_usb_read_bulk_callback()

commit e84f44eb5523401faeb9cc1c97895b68e3cfb78d upstream.

The conditon in the while-loop becomes true when actual_length is less than
2 (MSG_HEADER_LEN). In best case we end up with a former, already
dispatched msg, that got msg->len greater than actual_length. This will
result in a "Format error" error printout.

Problem seen when unplugging a Kvaser USB device connected to a vbox guest.

warning: comparison between signed and unsigned integer expressions
[-Wsign-compare]

Signed-off-by: Jimmy Assarsson <jimmyassarsson@gmail.com>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/can/usb/kvaser_usb.c