]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: fix reference leak in usb_new_device()
authorMa Ke <make_ruc2021@163.com>
Wed, 18 Dec 2024 07:13:46 +0000 (15:13 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jan 2025 12:34:45 +0000 (13:34 +0100)
commitdc51b66ec291c737783909cc30bece6698df9d66
treedf210e4cd0390bbe2a6b84ce6548d88cde74a9bd
parentc6f763b54c6bed424dfd508ccc520f6a884be6e3
usb: fix reference leak in usb_new_device()

commit 0df11fa8cee5a9cf8753d4e2672bb3667138c652 upstream.

When device_add(&udev->dev) succeeds and a later call fails,
usb_new_device() does not properly call device_del(). As comment of
device_add() says, 'if device_add() succeeds, you should call
device_del() when you want to get rid of it. If device_add() has not
succeeded, use only put_device() to drop the reference count'.

Found by code review.

Cc: stable <stable@kernel.org>
Fixes: 9f8b17e643fe ("USB: make usbdevices export their device nodes instead of using a separate class")
Signed-off-by: Ma Ke <make_ruc2021@163.com>
Reviewed-by: Alan Stern <stern@rowland.harvard.edu>
Link: https://lore.kernel.org/r/20241218071346.2973980-1-make_ruc2021@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/core/hub.c