]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: firewire: Using uninitialized values in node_probe()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 8 May 2020 14:40:22 +0000 (16:40 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Aug 2020 06:23:51 +0000 (08:23 +0200)
commitdc84d093ba5fb591aa110b1cb741f6a6f296c888
tree281a8633730bf87d1edaf87a0de59711cb772625
parent2cc4eecf58dd2a95fa0eeabf18f7702e0432921e
media: firewire: Using uninitialized values in node_probe()

[ Upstream commit 2505a210fc126599013aec2be741df20aaacc490 ]

If fw_csr_string() returns -ENOENT, then "name" is uninitialized.  So
then the "strlen(model_names[i]) <= name_len" is true because strlen()
is unsigned and -ENOENT is type promoted to a very high positive value.
Then the "strncmp(name, model_names[i], name_len)" uses uninitialized
data because "name" is uninitialized.

Fixes: 92374e886c75 ("[media] firedtv: drop obsolete backend abstraction")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/firewire/firedtv-fw.c