]> git.ipfire.org Git - thirdparty/linux.git/commit
tcp: use WRITE_ONCE() for tsoffset in tcp_v6_connect()
authorWesley Atwell <atwellwea@gmail.com>
Tue, 10 Mar 2026 01:26:04 +0000 (19:26 -0600)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Mar 2026 03:20:03 +0000 (20:20 -0700)
commitdc9902bbd480aae510b885b67cd30cd04cfce3a8
tree99e19d12fa0d4ad8a3c1899bcb206382fc6ddfbc
parent87aa0f539df0c190be7b565c1f32f9f90bf3869f
tcp: use WRITE_ONCE() for tsoffset in tcp_v6_connect()

Commit dd23c9f1e8d5 ("tcp: annotate data-races around tp->tsoffset")
updated do_tcp_getsockopt() to read tp->tsoffset with READ_ONCE()
for TCP_TIMESTAMP because another CPU may change it concurrently.

tcp_v6_connect() still stores tp->tsoffset with a plain write. That
store runs under lock_sock() via inet_stream_connect(), but the socket
lock does not serialize a concurrent getsockopt(TCP_TIMESTAMP) from
another task sharing the socket.

Use WRITE_ONCE() for the tcp_v6_connect() store so the connect-time
writer matches the lockless TCP_TIMESTAMP reader. This also makes the
IPv6 path consistent with tcp_v4_connect().

Signed-off-by: Wesley Atwell <atwellwea@gmail.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Jiayuan Chen <jiayuan.chen@shopee.com>
Link: https://patch.msgid.link/20260310012604.145661-1-atwellwea@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/tcp_ipv6.c