]> git.ipfire.org Git - thirdparty/libvirt.git/commit
xen_xs: Guard against set but empty kernel argument
authorGuido Günther <agx@sigxcpu.org>
Mon, 10 Oct 2011 16:22:44 +0000 (18:22 +0200)
committerGuido Günther <agx@sigxcpu.org>
Mon, 10 Oct 2011 20:58:04 +0000 (22:58 +0200)
commitdca1a6b46fecca57eac8914f30ad5a41a9f038fe
tree97bef3e765eabcf1c80ce417bad3cbc3251065d3
parentc5d2984c4270d257a5c01c236ca086162fd2849d
xen_xs: Guard against set but empty kernel argument

On xen 4.1 I observed configurations that look like:

(image
    (hvm
        (kernel '')
        (loader '/foo/bar')
))

The kernel element is there but unset. This leads to an empty <kernel/>
element in the XML and even worse makes us skip the boot order parsing
and therefore not emit a <boot device='$dev>'/> element which breaks CD
booting.
src/xenxs/xen_sxpr.c
tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.sexpr [new file with mode: 0644]
tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml [new file with mode: 0644]
tests/sexpr2xmltest.c