]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
NFS: Avoid flushing data while holding directory locks in nfs_rename()
authorTrond Myklebust <trond.myklebust@hammerspace.com>
Sun, 27 Apr 2025 22:21:06 +0000 (18:21 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 4 Jun 2025 12:40:26 +0000 (14:40 +0200)
commitdcabad63e07e9494faf932184b1eef22032c974e
tree0fe9423f9ff20c1d7a52b7d9a6ffe0ce0f20926d
parente1143267e928ff012cf0a88bb7622946278a96e1
NFS: Avoid flushing data while holding directory locks in nfs_rename()

[ Upstream commit dcd21b609d4abc7303f8683bce4f35d78d7d6830 ]

The Linux client assumes that all filehandles are non-volatile for
renames within the same directory (otherwise sillyrename cannot work).
However, the existence of the Linux 'subtree_check' export option has
meant that nfs_rename() has always assumed it needs to flush writes
before attempting to rename.

Since NFSv4 does allow the client to query whether or not the server
exhibits this behaviour, and since knfsd does actually set the
appropriate flag when 'subtree_check' is enabled on an export, it
should be OK to optimise away the write flushing behaviour in the cases
where it is clearly not needed.

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/nfs/client.c
fs/nfs/dir.c
include/linux/nfs_fs_sb.h