]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ipc/sem.c: fully initialize sem_array before making it visible
authorManfred Spraul <manfred@colorfullife.com>
Tue, 2 Dec 2014 23:59:34 +0000 (15:59 -0800)
committerJiri Slaby <jslaby@suse.cz>
Thu, 9 Apr 2015 11:14:24 +0000 (13:14 +0200)
commitdd06a9623b7e811b362f248bfc1d3886b0e8add1
tree0582646e8dbd6c7b6da8e0a00de3b913e487101d
parentda95a0de5c59732c942e9753ecc9c03c3783d33d
ipc/sem.c: fully initialize sem_array before making it visible

commit e8577d1f0329d4842e8302e289fb2c22156abef4 upstream.

ipc_addid() makes a new ipc identifier visible to everyone.  New objects
start as locked, so that the caller can complete the initialization
after the call.  Within struct sem_array, at least sma->sem_base and
sma->sem_nsems are accessed without any locks, therefore this approach
doesn't work.

Thus: Move the ipc_addid() to the end of the initialization.

Signed-off-by: Manfred Spraul <manfred@colorfullife.com>
Reported-by: Rik van Riel <riel@redhat.com>
Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Davidlohr Bueso <dave@stgolabs.net>
Acked-by: Rafael Aquini <aquini@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
ipc/sem.c