]> git.ipfire.org Git - thirdparty/linux.git/commit
SUNRPC: fix gss_auth kref leak in gss_alloc_msg error path
authorDaniel Hodges <git@danielhodges.dev>
Fri, 6 Feb 2026 20:41:46 +0000 (15:41 -0500)
committerAnna Schumaker <anna.schumaker@oracle.com>
Mon, 9 Feb 2026 21:39:50 +0000 (16:39 -0500)
commitdd2fdc3504592d85e549c523b054898a036a6afe
tree2c4027f4c93892cce2745f109bccb870d67ed167
parent1075e8e826b27aac92925c44d6d3c794e4d2ce0b
SUNRPC: fix gss_auth kref leak in gss_alloc_msg error path

Commit 5940d1cf9f42 ("SUNRPC: Rebalance a kref in auth_gss.c") added
a kref_get(&gss_auth->kref) call to balance the gss_put_auth() done
in gss_release_msg(), but forgot to add a corresponding kref_put()
on the error path when kstrdup_const() fails.

If service_name is non-NULL and kstrdup_const() fails, the function
jumps to err_put_pipe_version which calls put_pipe_version() and
kfree(gss_msg), but never releases the gss_auth reference. This leads
to a kref leak where the gss_auth structure is never freed.

Add a forward declaration for gss_free_callback() and call kref_put()
in the err_put_pipe_version error path to properly release the
reference taken earlier.

Fixes: 5940d1cf9f42 ("SUNRPC: Rebalance a kref in auth_gss.c")
Cc: stable@vger.kernel.org
Signed-off-by: Daniel Hodges <git@danielhodges.dev>
Signed-off-by: Anna Schumaker <anna.schumaker@oracle.com>
net/sunrpc/auth_gss/auth_gss.c