]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tg3: Hold tp->lock before calling tg3_halt() from tg3_init_one()
authorJun'ichi Nomura \\\\(NEC\\\\) <j-nomura@ce.jp.nec.com>
Thu, 12 Feb 2015 01:26:24 +0000 (01:26 +0000)
committerSasha Levin <sasha.levin@oracle.com>
Mon, 27 Apr 2015 21:13:42 +0000 (17:13 -0400)
commitdd6903432858c88c0b277f936352af248da9fe7e
tree02b059fe530d2b1b9f72a5361841ef67b481e823
parente083cde25c210e1960a3fbfe71c9ada4f9148a26
tg3: Hold tp->lock before calling tg3_halt() from tg3_init_one()

[ Upstream commit d0af71a3573f1217b140c60b66f1a9b335fb058b ]

tg3_init_one() calls tg3_halt() without tp->lock despite its assumption
and causes deadlock.
If lockdep is enabled, a warning like this shows up before the stall:

  [ BUG: bad unlock balance detected! ]
  3.19.0test #3 Tainted: G            E
  -------------------------------------
  insmod/369 is trying to release lock (&(&tp->lock)->rlock) at:
  [<ffffffffa02d5a1d>] tg3_chip_reset+0x14d/0x780 [tg3]
  but there are no more locks to release!

tg3_init_one() doesn't call tg3_halt() under normal situation but
during kexec kdump I hit this problem.

Fixes: 932f19de ("tg3: Release tp->lock before invoking synchronize_irq()")
Signed-off-by: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/net/ethernet/broadcom/tg3.c