]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
driver core: Fix error handling in driver API device_rename()
authorZijun Hu <quic_zijuhu@quicinc.com>
Mon, 22 Jul 2024 14:48:10 +0000 (22:48 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:29:39 +0000 (16:29 +0200)
commitdd69fb026c97b57b09a286b7f250f4ee2b7460a0
tree091f4b12a9c1c7fe954e3d4fc70bb9401165ef48
parent0f115888eaa9533506aaae170b59fed8e77ebbd4
driver core: Fix error handling in driver API device_rename()

[ Upstream commit 6d8249ac29bc23260dfa9747eb398ce76012d73c ]

For class-device, device_rename() failure maybe cause unexpected link name
within its class folder as explained below:

/sys/class/.../old_name -> /sys/devices/.../old_name
device_rename(..., new_name) and failed
/sys/class/.../new_name -> /sys/devices/.../old_name

Fixed by undoing renaming link if renaming kobject failed.

Fixes: f349cf34731c ("driver core: Implement ns directory support for device classes.")
Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
Link: https://lore.kernel.org/r/20240722-device_rename_fix-v2-1-77de1a6c6495@quicinc.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/base/core.c