]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: marvell: prestera: fix FEC error message for SFP ports
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Thu, 5 Feb 2026 09:19:55 +0000 (01:19 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 7 Feb 2026 04:05:09 +0000 (20:05 -0800)
commitdddb0198c2a887c2eba1a8b0113b46b648163048
tree89d9df5f7364f68eb06d7c1cec90092462417046
parent2214aab26811c77a15fc1d28bf3112a07b8c8d85
net: marvell: prestera: fix FEC error message for SFP ports

In prestera_ethtool_set_fecparam(), the error message is opposite of
the condition checking PRESTERA_PORT_TCVR_SFP. FEC configuration is
not allowed on SFP ports, but the message says "non-SFP ports", which
does not match the condition. However, FEC may be required depending on
the transceiver, cable, or mode, and firmware already validates invalid
combinations.

Remove the SFP transceiver check and let firmware handle validation.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Acked-by: Elad Nachman <enachman@marvell.com>
Link: https://patch.msgid.link/20260205091958.231413-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/prestera/prestera_ethtool.c