]> git.ipfire.org Git - thirdparty/libvirt.git/commit
maint: exempt graphic binaries from syntax check
authorEric Blake <eblake@redhat.com>
Tue, 10 Jun 2014 19:34:07 +0000 (13:34 -0600)
committerEric Blake <eblake@redhat.com>
Wed, 11 Jun 2014 14:41:37 +0000 (08:41 -0600)
commitde43582bf51fb5d857ee5b615c6514061213fdec
treeb9830e5520e6daf9e17ca112f4c5189c4bb2c29f
parentedc80e23442526bb24d35e46ace2d9632803815f
maint: exempt graphic binaries from syntax check

Roman Bogorodskiy reported a syntax-check failure when using
FreeBSD; complaining that:

prohibit_empty_first_line
tools/libvirt_win_icon_16x16.ico:1:
tools/libvirt_win_icon_32x32.ico:1:
tools/libvirt_win_icon_48x48.ico:1:
tools/libvirt_win_icon_64x64.ico:1:
maint.mk: Prohibited empty first line

In reality, the first 'line' of that file is NOT empty; but since
it is a binary file, awk is not required to handle it gracefully.
The simplest solution is to exempt all image files from syntax
checks in the first place - after all, we only store them in git
because they are inconvenient to regenerate, but they are not our
preferred format for making modifications, and syntax check should
only cover files that we are likely to modify.

* cfg.mk (VC_LIST_ALWAYS_EXCLUDE_REGEX): Exempt images.
(exclude_file_name_regexp--sc_prohibit_empty_lines_at_EOF): Simplify.
(exclude_file_name_regexp--sc_trailing_blank): Likewise.

Signed-off-by: Eric Blake <eblake@redhat.com>
cfg.mk