]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
platform/x86: hp-wmi: Make buffer for HPWMI_FEATURE2_QUERY 128 bytes
authorHans de Goede <hdegoede@redhat.com>
Tue, 17 Dec 2019 19:06:04 +0000 (20:06 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 28 Apr 2020 18:03:08 +0000 (19:03 +0100)
commitdea7e0f877379272e3dc1b274ff47a844fb0b29e
tree3eeed350e9fcb4de2de9059d8968b23e96f484a1
parent9a6c2819cb43b3844ccddb009b92b6350973ca0f
platform/x86: hp-wmi: Make buffer for HPWMI_FEATURE2_QUERY 128 bytes

commit 133b2acee3871ae6bf123b8fe34be14464aa3d2c upstream.

At least on the HP Envy x360 15-cp0xxx model the WMI interface
for HPWMI_FEATURE2_QUERY requires an outsize of at least 128 bytes,
otherwise it fails with an error code 5 (HPWMI_RET_INVALID_PARAMETERS):

Dec 06 00:59:38 kernel: hp_wmi: query 0xd returned error 0x5

We do not care about the contents of the buffer, we just want to know
if the HPWMI_FEATURE2_QUERY command is supported.

This commits bumps the buffer size, fixing the error.

Fixes: 8a1513b4932 ("hp-wmi: limit hotkey enable")
BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1520703
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
[bwh: Backported to 3.16: adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/platform/x86/hp-wmi.c