]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
usb: renesas_usbhs: fix NULL pointer dereference in xfer_work()
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Wed, 8 Jun 2016 07:32:49 +0000 (16:32 +0900)
committerSasha Levin <alexander.levin@verizon.com>
Mon, 22 Aug 2016 16:23:02 +0000 (12:23 -0400)
commitdf09c5633071d21d3f9563d6ff3e6c9ff8696732
tree7a634e5a8ca18ef428b76fe614be02707d36be43
parent68960057e584cc367a6ae7e4737bbc240651aaec
usb: renesas_usbhs: fix NULL pointer dereference in xfer_work()

[ Upstream commit 4fdef698383db07d829da567e0e405fc41ff3a89 ]

This patch fixes an issue that the xfer_work() is possible to cause
NULL pointer dereference if the usb cable is disconnected while data
transfer is running.

In such case, a gadget driver may call usb_ep_disable()) before
xfer_work() is actually called. In this case, the usbhs_pkt_pop()
will call usbhsf_fifo_unselect(), and then usbhs_pipe_to_fifo()
in xfer_work() will return NULL.

Fixes: e73a989 ("usb: renesas_usbhs: add DMAEngine support")
Cc: <stable@vger.kernel.org> # v3.1+
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
drivers/usb/renesas_usbhs/fifo.c