]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/gem: Inline drm_gem_pin() into PRIME helpers
authorThomas Zimmermann <tzimmermann@suse.de>
Mon, 26 May 2025 13:25:20 +0000 (15:25 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 30 May 2025 07:47:28 +0000 (09:47 +0200)
commitdf1c3093aee3daee4d56a5cb8cdba75c1ef6962f
tree530e5312d9dea78cd2986de2885be7f1e3ddcdfd
parent3c89f2d85c39506772c65f44b3013b111d23dafc
drm/gem: Inline drm_gem_pin() into PRIME helpers

Inline drm_gem_pin() into its only caller drm_gem_map_attach()
and update the documentation in the callback's purpose. Do the
equivalent for drm_gem_unpin(). Also add stricter error checking
on the involved locking.

The pin operation in the GEM object functions is a helper for
PRIME-exported buffer objects. Having drm_gem_pin() gives the
impression of a general-purpose interface, which is not the case.
Removing it makes the pin callback a bit harder to misuse.

v2:
- clarify comment on pin callback (Dmitry)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Link: https://lore.kernel.org/r/20250526132634.531789-5-tzimmermann@suse.de
drivers/gpu/drm/drm_gem.c
drivers/gpu/drm/drm_internal.h
drivers/gpu/drm/drm_prime.c
include/drm/drm_gem.h