]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/msm/dpu: don't play tricks with debug macros
authorDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fri, 2 Aug 2024 19:47:34 +0000 (22:47 +0300)
committerAbhinav Kumar <quic_abhinavk@quicinc.com>
Mon, 5 Aug 2024 20:44:25 +0000 (13:44 -0700)
commitdf24373435f5899a2a98b7d377479c8d4376613b
treea395f626602627be23b56cae177108387f14f9ed
parentfe34394ecdad459d2d7b1f30e4a39ac27fcd77f8
drm/msm/dpu: don't play tricks with debug macros

DPU debugging macros need to be converted to a proper drm_debug_*
macros, however this is a going an intrusive patch, not suitable for a
fix. Wire DPU_DEBUG and DPU_DEBUG_DRIVER to always use DRM_DEBUG_DRIVER
to make sure that DPU debugging messages always end up in the drm debug
messages and are controlled via the usual drm.debug mask.

I don't think that it is a good idea for a generic DPU_DEBUG macro to be
tied to DRM_UT_KMS. It is used to report a debug message from driver, so by
default it should go to the DRM_UT_DRIVER channel. While refactoring
debug macros later on we might end up with particular messages going to
ATOMIC or KMS, but DRIVER should be the default.

Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Patchwork: https://patchwork.freedesktop.org/patch/606932/
Link: https://lore.kernel.org/r/20240802-dpu-fix-wb-v2-2-7eac9eb8e895@linaro.org
Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h