]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
Revert "net/smc: Introduce TCP ULP support"
authorD. Wythe <alibuda@linux.alibaba.com>
Wed, 28 Jan 2026 05:54:52 +0000 (13:54 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 31 Jan 2026 03:21:51 +0000 (19:21 -0800)
commitdf31a6b0a3057e66994ad6ccf5d95b9b9514f033
tree8339323fd94ba378ee851587adb56a54022e0c9f
parent82fff3b055d498bde37104eab219be25af3ddbe9
Revert "net/smc: Introduce TCP ULP support"

This reverts commit d7cd421da9da2cc7b4d25b8537f66db5c8331c40.

As reported by Al Viro, the TCP ULP support for SMC is fundamentally
broken. The implementation attempts to convert an active TCP socket
into an SMC socket by modifying the underlying `struct file`, dentry,
and inode in-place, which violates core VFS invariants that assume
these structures are immutable for an open file, creating a risk of
use after free errors and general system instability.

Given the severity of this design flaw and the fact that cleaner
alternatives (e.g., LD_PRELOAD, BPF) exist for legacy application
transparency, the correct course of action is to remove this feature
entirely.

Fixes: d7cd421da9da ("net/smc: Introduce TCP ULP support")
Link: https://lore.kernel.org/netdev/Yus1SycZxcd+wHwz@ZenIV/
Reported-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: D. Wythe <alibuda@linux.alibaba.com>
Reviewed-by: Tony Lu <tonylu@linux.alibaba.com>
Reviewed-by: Dust Li <dust.li@linux.alibaba.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260128055452.98251-1-alibuda@linux.alibaba.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/smc/af_smc.c