]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net/mlx5: free mlx5_st_idx_data on final dealloc
authorZhiping Zhang <zhipingz@meta.com>
Thu, 2 Jul 2026 22:24:58 +0000 (15:24 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Fri, 17 Jul 2026 09:50:02 +0000 (11:50 +0200)
commitdf6134b527a88b3e65ba6ae5073664af091d5fd2
treea8a02b0fd15f1197dc1c77cce73c652bc2bd426d
parent892d3087c4fcee2cd9a8dbc0e9a0e5cda4827910
net/mlx5: free mlx5_st_idx_data on final dealloc

Workloads that repeatedly allocate and release mkeys carrying TPH
steering-tag hints (e.g. churning RDMA MRs) leak one
struct mlx5_st_idx_data per cycle; kmemleak flags it as unreferenced
and the kmalloc slab grows over time.

When the last reference to an ST table entry is dropped,
mlx5_st_dealloc_index() removed the entry from idx_xa but the backing
mlx5_st_idx_data allocation was never freed.

Free idx_data after the xa_erase() so the lifetime of the bookkeeping
struct matches the lifetime of the ST entry it tracks.

Cc: stable@vger.kernel.org
Fixes: 888a7776f4fb ("net/mlx5: Add support for device steering tag")
Reviewed-by: Michael Gur <michaelgur@nvidia.com>
Signed-off-by: Zhiping Zhang <zhipingz@meta.com>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20260702222507.1234467-1-zhipingz@meta.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/mellanox/mlx5/core/lib/st.c