]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: airoha: fix potential use-after-free in airoha_npu_get()
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Tue, 15 Jul 2025 14:30:58 +0000 (07:30 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 24 Jul 2025 06:58:38 +0000 (08:58 +0200)
commitdf6bf96b41e547e350667bc4c143be53646d070d
treec237d30ee87e9caf80a8849adc02d5e6521bbc65
parent3e7a009f0aee0b6e5e988b16a93152c8c49065c5
net: airoha: fix potential use-after-free in airoha_npu_get()

[ Upstream commit 3cd582e7d0787506990ef0180405eb6224fa90a6 ]

np->name was being used after calling of_node_put(np), which
releases the node and can lead to a use-after-free bug.
Previously, of_node_put(np) was called unconditionally after
of_find_device_by_node(np), which could result in a use-after-free if
pdev is NULL.

This patch moves of_node_put(np) after the error check to ensure
the node is only released after both the error and success cases
are handled appropriately, preventing potential resource issues.

Fixes: 23290c7bc190 ("net: airoha: Introduce Airoha NPU support")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20250715143102.3458286-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/airoha/airoha_npu.c