]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
RDMA/rxe: Compute PSN windows correctly
authorBob Pearson <rpearsonhpe@gmail.com>
Tue, 13 Oct 2020 17:07:42 +0000 (12:07 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:25:50 +0000 (11:25 +0100)
commite02d63b00889661e868035d80bbcdbb687dedaf0
tree34d64e9d297569e6ff44b6067f33420b3563d874
parent620974102ad8ed5641f805dfec7e75765c3d2df9
RDMA/rxe: Compute PSN windows correctly

[ Upstream commit bb3ab2979fd69db23328691cb10067861df89037 ]

The code which limited the number of unacknowledged PSNs was incorrect.
The PSNs are limited to 24 bits and wrap back to zero from 0x00ffffff.
The test was computing a 32 bit value which wraps at 32 bits so that
qp->req.psn can appear smaller than the limit when it is actually larger.

Replace '>' test with psn_compare which is used for other PSN comparisons
and correctly handles the 24 bit size.

Fixes: 8700e3e7c485 ("Soft RoCE driver")
Link: https://lore.kernel.org/r/20201013170741.3590-1-rpearson@hpe.com
Signed-off-by: Bob Pearson <rpearson@hpe.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/sw/rxe/rxe_req.c