]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tg3: Fix for tg3 transmit queue 0 timed out when too many gso_segs
authorSiva Reddy Kallam <siva.kallam@broadcom.com>
Wed, 3 Feb 2016 08:39:38 +0000 (14:09 +0530)
committerJiri Slaby <jslaby@suse.cz>
Wed, 2 Mar 2016 15:29:08 +0000 (16:29 +0100)
commite03e0613e6333d3cd5c322f6486273b98e007882
tree8ce50d77fa3d4efd837b3d3755dba7f6725f49e1
parent1ad3dfa534e42404edcca40e440b78976f8f99c3
tg3: Fix for tg3 transmit queue 0 timed out when too many gso_segs

[ Upstream commit b7d987295c74500b733a0ba07f9a9bcc4074fa83 ]

tg3_tso_bug() can hit a condition where the entire tx ring is not big
enough to segment the GSO packet. For example, if MSS is very small,
gso_segs can exceed the tx ring size. When we hit the condition, it
will cause tx timeout.

tg3_tso_bug() is called to handle TSO and DMA hardware bugs.
For TSO bugs, if tg3_tso_bug() cannot succeed, we have to drop the packet.
For DMA bugs, we can still fall back to linearize the SKB and let the
hardware transmit the TSO packet.

This patch adds a function tg3_tso_bug_gso_check() to check if there
are enough tx descriptors for GSO before calling tg3_tso_bug().
The caller will then handle the error appropriately - drop or
lineraize the SKB.

v2: Corrected patch description to avoid confusion.

Signed-off-by: Siva Reddy Kallam <siva.kallam@broadcom.com>
Signed-off-by: Michael Chan <mchan@broadcom.com>
Acked-by: Prashant Sreedharan <prashant@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/net/ethernet/broadcom/tg3.c