]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
OPP: Fix passing 0 to PTR_ERR in _opp_attach_genpd()
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Fri, 21 Jul 2023 12:46:34 +0000 (18:16 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Sep 2023 10:22:31 +0000 (12:22 +0200)
commite0478944f4a5d4be734675aac1120b978ef893ab
tree768efd731321d0f5ae5e853c5b671834210dcf0d
parentec9d118ad99dc6f1bc674c1e649c25533d89b9ba
OPP: Fix passing 0 to PTR_ERR in _opp_attach_genpd()

[ Upstream commit d920920f85a82c1c806a4143871a0e8f534732f2 ]

If dev_pm_domain_attach_by_name() returns NULL, then 0 will be passed to
PTR_ERR() as reported by the smatch warning below:

drivers/opp/core.c:2456 _opp_attach_genpd() warn: passing zero to 'PTR_ERR'

Fix it by checking for the non-NULL virt_dev pointer before passing it to
PTR_ERR. Otherwise return -ENODEV.

Fixes: 4ea9496cbc95 ("opp: Fix error check in dev_pm_opp_attach_genpd()")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/opp/core.c