]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Revert "nfp: abm: fix memory leak in nfp_abm_u32_knode_replace"
authorJakub Kicinski <jakub.kicinski@netronome.com>
Tue, 10 Dec 2019 18:20:32 +0000 (10:20 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Feb 2020 07:36:36 +0000 (08:36 +0100)
commite07c107a24835a6eb15f7b2c2eb6c0e0c0e4583c
tree24711700388cc106d679e2ae3a7f8c2b855cdec1
parent6a05af0b718a2a9fc78efbda20a80b16587174df
Revert "nfp: abm: fix memory leak in nfp_abm_u32_knode_replace"

[ Upstream commit 1d1997db870f4058676439ef7014390ba9e24eb2 ]

This reverts commit 78beef629fd9 ("nfp: abm: fix memory leak in
nfp_abm_u32_knode_replace").

The quoted commit does not fix anything and resulted in a bogus
CVE-2019-19076.

If match is NULL then it is known there is no matching entry in
list, hence, calling nfp_abm_u32_knode_delete() is pointless.

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: John Hurley <john.hurley@netronome.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/netronome/nfp/abm/cls.c