]> git.ipfire.org Git - thirdparty/linux.git/commit
phy: rockchip: inno-usb2: Fix a double free bug in rockchip_usb2phy_probe()
authorWentao Liang <vulab@iscas.ac.cn>
Fri, 9 Jan 2026 15:46:26 +0000 (15:46 +0000)
committerVinod Koul <vkoul@kernel.org>
Wed, 14 Jan 2026 13:37:44 +0000 (19:07 +0530)
commite07dea3de508cd6950c937cec42de7603190e1ca
tree41357a37f394e35c132d500133ee637748ad157e
parentfb21116099bbea1fc59efa9207e63c4be390ab72
phy: rockchip: inno-usb2: Fix a double free bug in rockchip_usb2phy_probe()

The for_each_available_child_of_node() calls of_node_put() to
release child_np in each success loop. After breaking from the
loop with the child_np has been released, the code will jump to
the put_child label and will call the of_node_put() again if the
devm_request_threaded_irq() fails. These cause a double free bug.

Fix by returning directly to avoid the duplicate of_node_put().

Fixes: ed2b5a8e6b98 ("phy: phy-rockchip-inno-usb2: support muxed interrupts")
Cc: stable@vger.kernel.org
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/20260109154626.2452034-1-vulab@iscas.ac.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/rockchip/phy-rockchip-inno-usb2.c