]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
Input: cros_ec_keyb - fix an invalid memory access
authorTzung-Bi Shih <tzungbi@kernel.org>
Tue, 4 Nov 2025 07:03:10 +0000 (07:03 +0000)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 5 Nov 2025 00:03:26 +0000 (16:03 -0800)
commite08969c4d65ac31297fcb4d31d4808c789152f68
tree8d411f09404b850e40d64b68f8eac8e22aeaadfd
parentd83f1512758f4ef6fc5e83219fe7eeeb6b428ea4
Input: cros_ec_keyb - fix an invalid memory access

If cros_ec_keyb_register_matrix() isn't called (due to
`buttons_switches_only`) in cros_ec_keyb_probe(), `ckdev->idev` remains
NULL.  An invalid memory access is observed in cros_ec_keyb_process()
when receiving an EC_MKBP_EVENT_KEY_MATRIX event in cros_ec_keyb_work()
in such case.

  Unable to handle kernel read from unreadable memory at virtual address 0000000000000028
  ...
  x3 : 0000000000000000 x2 : 0000000000000000
  x1 : 0000000000000000 x0 : 0000000000000000
  Call trace:
  input_event
  cros_ec_keyb_work
  blocking_notifier_call_chain
  ec_irq_thread

It's still unknown about why the kernel receives such malformed event,
in any cases, the kernel shouldn't access `ckdev->idev` and friends if
the driver doesn't intend to initialize them.

Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://patch.msgid.link/20251104070310.3212712-1-tzungbi@kernel.org
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/cros_ec_keyb.c