Pull request #4263: Public enemy 1

Pull request #4263: Public enemy 1

Merge in SNORT/snort3 from ~RUCOMBS/snort3:public_enemy_1 to master

Squashed commit of the following:

commit 7f8f2135c33fd2de3495a8edcfd22b5f60de89fd
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed May 8 14:22:49 2024 -0400

    build: fix coverity warnings

commit 2c700829076b77e7d2773d102a2a62d4d3b531b1
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed May 8 13:42:06 2024 -0400

    build: fix bogus cppcheck warnings

commit eb7b28eea14ea6e8c5152945c6204cc37bad8196
Author: Russ Combs <rucombs@cisco.com>
Date:   Fri Apr 12 10:06:47 2024 -0400

    framework: bump api version to 20

commit c9a5baeeb2e3a7954b492179faac32b2696876ab
Author: Russ Combs <rucombs@cisco.com>
Date:   Mon Apr 8 13:37:48 2024 -0400

    snort: remove deprecated features:

    Config:

    string binder[].when.zones: deprecated alias for groups
    string binder[].when.src_zone: deprecated alias for src_groups
    string binder[].when.dst_zone: deprecated alias for dst_groups
    enum dce_smb.smb_file_inspection: deprecated (not used): file inspection controlled by smb_file_depth { 'off' | 'on' | 'only' }
    int sip.max_requestName_len = 20: deprecated - use max_request_name_len instead { 0:65535 }

    Builtins:

    129:5 (stream_tcp) bad segment, adjusted size <= 0 (deprecated)

commit 641cad2638d6eb1bd0a57982d1354b829ee08147
Author: Russ Combs <rucombs@cisco.com>
Date:   Thu Apr 4 10:11:54 2024 -0400

    pig_pen: use Module::usage directly

commit 0a6d7eccebac6e1d0d2b478094f31f296103371e
Author: Russ Combs <rucombs@cisco.com>
Date:   Tue Mar 19 10:21:58 2024 -0400

    mpse: add modules for pegs and perf profiling; remove _search

commit 818d4709d70430595e73ee6301f35a376f5e8d78
Author: Russ Combs <rucombs@cisco.com>
Date:   Thu Mar 14 11:20:49 2024 -0400

    framework: improve exported header comments

commit a53c0249b7047c26328a5bbd14e0bc706df88214
Author: Russ Combs <rucombs@cisco.com>
Date:   Mon Mar 11 08:39:57 2024 -0400

    plugins: add missing error messages when an so fails to load

commit 1c7fd7e717d06231565cff00a73e4a5937749638
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed Mar 6 10:44:29 2024 -0500

    flow: move StreamFlowIntf to stream_flow.h

commit b4f969f4072a45b12acd3a36808746414af707c0
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed Mar 6 09:03:10 2024 -0500

    framework: generate preprocessor output for validation

commit 14e9886e9018a11a8f98ec95d88c127aed2e6f6e
Author: Russ Combs <rucombs@cisco.com>
Date:   Mon Mar 4 09:56:53 2024 -0500

    doc: add versioning information to the developer guide

commit f1074aaa9c79b9e1a91616f9e0da533e872c8f2b
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed Feb 28 08:46:20 2024 -0500

    host_cache: do not install private header

commit c8d50a4ba02f527efe6ca89e5ad07991c9bd18c9
Author: Russ Combs <rucombs@cisco.com>
Date:   Mon Feb 26 09:26:31 2024 -0500

    api: refactor base API

commit 1c9fe59accaf77c84ba6a627be66072d02f0d87f
Author: Russ Combs <rucombs@cisco.com>
Date:   Thu Feb 15 12:08:06 2024 -0500

    inspector: eval override is optional for passive inspectors

commit 48859035f007a5bcdc17b2e9be05da11742338d6
Author: Russ Combs <rucombs@cisco.com>
Date:   Tue Feb 13 16:22:08 2024 -0500

    plugins: add warning for invalid plugin types

commit ef2b94f2ba3a46efdd3455359bfeba51a4fcd87f
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed Jan 24 04:26:46 2024 -0500

    plugins: bump base API and all plugin API version numbers

commit 4636922ef31cdf8544ee5a62bba313f9577bfd19
Author: Russ Combs <rucombs@cisco.com>
Date:   Thu Nov 30 09:47:40 2023 -0500

    detection: refactor headers

commit b70ee339aa490d7562bab85418a4e2ab89ec6129
Author: Russ Combs <rucombs@cisco.com>
Date:   Tue Dec 12 12:37:39 2023 -0500

    ips: tweak check for offload enable

commit 047ec75da346b7d1199ef9122147ad89921468da
Author: Russ Combs <rucombs@cisco.com>
Date:   Mon Nov 27 14:56:29 2023 -0500

    build: fix LTO ODR issues with anonymous namespaces

commit eb975151c97018a8ede37115df312aa4ac29d66d
Author: Russ Combs <rucombs@cisco.com>
Date:   Mon Nov 13 12:04:34 2023 -0500

    inspector: use thread local slot for best perf on Linux

commit 0565783cbf6e2ffd65aeb0934040ec57464ce60a
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed Nov 8 14:29:34 2023 -0500

    extract: move extract methods to detection/

commit eaae3dc988df37c0312a218259ccdbb1d86a165d
Author: Russ Combs <rucombs@cisco.com>
Date:   Tue Nov 7 11:36:20 2023 -0500

    stats: change shutdown Mbits/sec from mebibits to megabits

commit ade482affc30c629dac43626d21d92b0488cd4dc
Author: Russ Combs <rucombs@cisco.com>
Date:   Mon Oct 9 11:12:14 2023 -0400

    appid: remove cruft left behind by f49fbbef

commit 1d36b3fe208ffdee2dd997746f9b6b3c251d3305
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed Oct 4 10:00:28 2023 -0400

    tag: tweak enable toggle

commit eebe7edb5f6947b81fc89604c1bf0261a0e070d1
Author: Russ Combs <rucombs@cisco.com>
Date:   Tue Sep 26 14:09:23 2023 -0400

    packet_tracer: eliminate SO_PUBLIC THREAD_LOCALs

commit 9ffcfdbebae661f6fc2c8c655996a9f37634cc26
Author: Russ Combs <rucombs@cisco.com>
Date:   Tue Sep 5 11:43:26 2023 -0400

    profiler: eliminate SO_PUBLIC THREAD_LOCALs for _WIN64

    This degrades performance so it is done only for Windows where SO_PUBLIC
    THREAD_LOCALs are not supported.

commit eac23069203da078d6deab67e13bad052c8f6731
Author: Russ Combs <rucombs@cisco.com>
Date:   Tue Aug 8 09:31:33 2023 -0400

    style: remove trailing spaces

commit 2d6882a33443d50c5f66495a1b62bb75bf4b6bb6
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed Sep 20 14:45:16 2023 -0400

    ssl: support dynamic build of inspector and ips options

commit e3dcb79941b03815867bd439885850270f754616
Author: Russ Combs <rucombs@cisco.com>
Date:   Tue Sep 19 16:16:24 2023 -0400

    ips_options: fix dynamic build of some options

commit 6991df8ab3e4c8d0d07b23436fa06695c244ca17
Author: Russ Combs <rucombs@cisco.com>
Date:   Fri Sep 15 12:50:57 2023 -0400

    profiler: move implementation class to profiler_impl.h

commit c67e74c070809c9eb9571c73637b40b71572ea62
Author: Russ Combs <rucombs@cisco.com>
Date:   Fri Sep 15 12:50:16 2023 -0400

    numa: do not install implementation (private) header

commit ec030aa7b77ad940ea1056078555dee9499e2098
Author: Russ Combs <rucombs@cisco.com>
Date:   Fri Sep 15 12:47:05 2023 -0400

    reputation: move private defines out of installed header

commit e3c5f4653fae5882d333dcbf12b796e3fc6f191c
Author: Russ Combs <rucombs@cisco.com>
Date:   Thu Sep 14 09:55:34 2023 -0400

    thread: move THREAD_LOCAL definition to snort_types.h

commit 2759519051f3972de590540f75c84b5ac1b5b3de
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed Sep 13 10:01:15 2023 -0400

    utils: refactor out non-public code

commit c3145c20f7ea175d046a0f676fa42533f679a469
Author: Russ Combs <rucombs@cisco.com>
Date:   Tue Sep 12 14:29:14 2023 -0400

    stats: stats.h is for internal use only, do not install

commit 92dbe63fb04b96264cf67feab80bd100370f99a2
Author: Russ Combs <rucombs@cisco.com>
Date:   Tue Sep 12 11:47:08 2023 -0400

    flow: split ExpectFlow into a separate header

commit 1366ef1571ae0cb9729ec75c3c8b81144f53c4eb
Author: Russ Combs <rucombs@cisco.com>
Date:   Mon Sep 11 15:36:59 2023 -0400

    src/: relocate packet_tracer, packet_constraints, and file_policy.

commit 7e3263c4db9f1b8dabf3c11014d124eff0a43ae9
Author: Russ Combs <rucombs@cisco.com>
Date:   Mon Sep 11 12:44:57 2023 -0400

    rna: refactor headers for better encapsulation

commit 39a74682069842d8777720a42be6592d0361aa53
Author: Russ Combs <rucombs@cisco.com>
Date:   Fri Sep 8 13:47:01 2023 -0400

    file: do not install internal headers

commit 7c532a3410df1a631fa3494360f06b4d3db008bf
Author: Russ Combs <rucombs@cisco.com>
Date:   Fri Sep 8 10:50:01 2023 -0400

    log: refactor out app implementation stuff into log_errors.h

commit 274d08bb2b2e6a8701d213d089d670345eb5d15f
Author: Russ Combs <rucombs@cisco.com>
Date:   Thu Sep 7 15:07:56 2023 -0400

    active, host_tracker, profiler, stats, stream: refactor installed headers to exclude implementation like counts and perf stats

commit 52915f8e0fc136fe52ce42570458e523beba36e9
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed Sep 6 14:44:07 2023 -0400

    detection: refactor detection_util.*

    Split detection_util.{h,cc} into detection_buf.h and event_trace.{h,cc}.

commit 76797daae3fcb788c7aa7e2c53a25456916c0522
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed Sep 6 11:38:36 2023 -0400

    helpers/, utils/: reorganize to meet original intent

    helpers/: C++ utility classes
    utils/: C-style functions and defines

commit d648be932b8d4c10cc144c5a597c3c9aab157e96
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed Aug 30 11:59:53 2023 -0400

    codecs: PacketManager::max_layers is not THREAD_LOCAL

commit 4826653a3bce0fc4043ab0cd4d2e933eae718b06
Author: Russ Combs <rucombs@cisco.com>
Date:   Wed Aug 30 11:30:31 2023 -0400

    inspectors: remove redundant slot variable

commit a08cc0edab6893917e3c6d1b2629d5a775ce4086
Author: Russ Combs <rucombs@cisco.com>
Date:   Tue Aug 29 15:39:50 2023 -0400

    build: eliminate SO_PUBLIC THREAD_LOCALs

commit 4dd23f34df05dfbd40f23016fbd57185079256ed
Author: Russ Combs <rucombs@cisco.com>
Date:   Mon Aug 28 13:57:31 2023 -0400

    event_filter, suppress:  keep antiquated dynamic array support private (use std::vector instead)

commit 8f65203a02be32128af0be21590b7d69b979889e
Author: Russ Combs <rucombs@cisco.com>
Date:   Mon Aug 28 12:15:21 2023 -0400

    stream: delete obsolete / unused methods

commit bd5770d0faa26e785180278879105ea05bdee44b
Author: Russ Combs <rucombs@cisco.com>
Date:   Fri Aug 25 15:07:15 2023 -0400

    tcp: move SEQ_* macros to tcp header

commit 511797508566d0d7c5da7c13afbedda531cdd49b
Author: Russ Combs <rucombs@cisco.com>
Date:   Fri Aug 25 13:22:13 2023 -0400

    style: miscellaneous cleanup

... and 18 more commits