]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
atm: solos-pci: Fix potential deadlock on &cli_queue_lock
authorChengfeng Ye <dg573847474@gmail.com>
Thu, 7 Dec 2023 12:34:37 +0000 (12:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Dec 2023 14:17:34 +0000 (15:17 +0100)
commite16f961f8bc5fe240f12afd8a4bc700002071157
treeef8fb2b71f7164124749a368b8cf83af6ec1aff7
parentd525bbd9dd2d225c3cc856ac341bb2da4c2b1aaf
atm: solos-pci: Fix potential deadlock on &cli_queue_lock

[ Upstream commit d5dba32b8f6cb39be708b726044ba30dbc088b30 ]

As &card->cli_queue_lock is acquired under softirq context along the
following call chain from solos_bh(), other acquisition of the same
lock inside process context should disable at least bh to avoid double
lock.

<deadlock #1>
console_show()
--> spin_lock(&card->cli_queue_lock)
<interrupt>
   --> solos_bh()
   --> spin_lock(&card->cli_queue_lock)

This flaw was found by an experimental static analysis tool I am
developing for irq-related deadlock.

To prevent the potential deadlock, the patch uses spin_lock_bh()
on the card->cli_queue_lock under process context code consistently
to prevent the possible deadlock scenario.

Fixes: 9c54004ea717 ("atm: Driver for Solos PCI ADSL2+ card.")
Signed-off-by: Chengfeng Ye <dg573847474@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/atm/solos-pci.c