]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: m5mols: Check function pointer in m5mols_sensor_power
authorTom Rix <trix@redhat.com>
Sun, 19 Jul 2020 15:34:47 +0000 (17:34 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 08:03:02 +0000 (09:03 +0100)
commite1c798aebcb8d9fb83848d6cabfcc0b2e247e94e
treef589243c26f380302be18f844d485122def01feb
parentf6af2c161ba4f21d5ec7f7a8fdaf162625763ac1
media: m5mols: Check function pointer in m5mols_sensor_power

[ Upstream commit 52438c4463ac904d14bf3496765e67750766f3a6 ]

clang static analysis reports this error

m5mols_core.c:767:4: warning: Called function pointer
  is null (null dereference) [core.CallAndMessage]
    info->set_power(&client->dev, 0);
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

In other places, the set_power ptr is checked.
So add a check.

Fixes: bc125106f8af ("[media] Add support for M-5MOLS 8 Mega Pixel camera ISP")
Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/i2c/m5mols/m5mols_core.c