]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commit
mkfs: inode/block size error messages confusing
authorDave Chinner <dchinner@redhat.com>
Mon, 11 May 2015 00:09:22 +0000 (10:09 +1000)
committerDave Chinner <david@fromorbit.com>
Mon, 11 May 2015 00:09:22 +0000 (10:09 +1000)
commite24ee60b7466effcfac2edfc6395dabfabb4a559
treea6e4a9723cf722f4ca982db492774ccb26026d61
parent566ebd5ae5fa4267c1789e72bc309207627220eb
mkfs: inode/block size error messages confusing

As reported by Brain:

# ./mkfs/mkfs.xfs -f /dev/test/scratch -b size=512
illegal inode size 512
allowable inode size with 512 byte blocks is 256
# ./mkfs/mkfs.xfs -f /dev/test/scratch -b size=512 -i size=256
Minimum inode size for CRCs is 512 bytes
Usage: mkfs.xfs
...

Fix mkfs to catch the block size as being too small, rather than
leaving it for inode size detection to enforce.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
include/xfs_types.h
mkfs/xfs_mkfs.c