]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
perf: Fix signed comparison in perf_adjust_period()
authorPeter Zijlstra <a.p.zijlstra@chello.nl>
Fri, 4 Jun 2010 13:18:01 +0000 (15:18 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 5 Jul 2010 18:16:07 +0000 (11:16 -0700)
commite26e13a7e153ae645a430c4983241b0e9987d5cf
tree52d915da4d749839c485ebe7e2b4e2c72b17427d
parent402d655a0d2df775bfcf345fcc19db8a32b3a1c8
perf: Fix signed comparison in perf_adjust_period()

commit f6ab91add6355e231e1c47897027b2a6ee4fa268 upstream.

Frederic reported that frequency driven swevents didn't work properly
and even caused a division-by-zero error.

It turns out there are two bugs, the division-by-zero comes from a
failure to deal with that in perf_calculate_period().

The other was more interesting and turned out to be a wrong comparison
in perf_adjust_period(). The comparison was between an s64 and u64 and
got implicitly converted to an unsigned comparison. The problem is
that period_left is typically < 0, so it ended up being always true.

Cure this by making the local period variables s64.

Reported-by: Frederic Weisbecker <fweisbec@gmail.com>
Tested-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
kernel/perf_event.c