]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net/mlx5: Fix memory leak in error flow of port set buffer
authorMaher Sanalla <msanalla@nvidia.com>
Tue, 17 Jan 2023 12:54:36 +0000 (14:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Dec 2025 21:12:36 +0000 (06:12 +0900)
commite2acd661fd29b9f209578e3a38c83c705b08e246
tree4d1f8b28d2c94ae33b8c7a650b0d732e5a3e473c
parent1d519c0f512f1db0562514e09a550090edf74af9
net/mlx5: Fix memory leak in error flow of port set buffer

commit e3e01c1c15986f9531b854634eec8381e72cb605 upstream.

In the cited commit, shared buffer updates were added whenever
port buffer gets updated.

However, in case the shared buffer update fails, exiting early from
port_set_buffer() is performed without freeing previously-allocated memory.

Fix it by jumping to out label where memory is freed before returning
with error.

Fixes: a440030d8946 ("net/mlx5e: Update shared buffer along with device buffer changes")
Signed-off-by: Maher Sanalla <msanalla@nvidia.com>
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/mellanox/mlx5/core/en/port_buffer.c