]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
xfs: remove file_path tracepoint data
authorDarrick J. Wong <djwong@kernel.org>
Mon, 23 Mar 2026 21:04:33 +0000 (14:04 -0700)
committerCarlos Maiolino <cem@kernel.org>
Thu, 26 Mar 2026 13:25:23 +0000 (14:25 +0100)
commite31c53a8060e134111ed095783fee0aa0c43b080
tree44595a1e3cc77da70ad48110e50166ccc624fbc3
parent70685c291ef82269180758130394ecdc4496b52c
xfs: remove file_path tracepoint data

The xfile/xmbuf shmem file descriptions are no longer as detailed as
they were when online fsck was first merged, because moving to static
strings in commit 60382993a2e180 ("xfs: get rid of the
xchk_xfile_*_descr calls") removed a memory allocation and hence a
source of failure.

However this makes encoding the description in the tracepoints sort of a
waste of memory.  David Laight also points out that file_path doesn't
zero the whole buffer which causes exposure of stale trace bytes, and
Steven Rostedt wonders why we're not using a dynamic array for the file
path.

I don't think this is worth fixing, so let's just rip it out.

Cc: rostedt@goodmis.org
Cc: david.laight.linux@gmail.com
Link: https://lore.kernel.org/linux-xfs/20260323172204.work.979-kees@kernel.org/
Cc: stable@vger.kernel.org # v6.11
Fixes: 19ebc8f84ea12e ("xfs: fix file_path handling in tracepoints")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/scrub/trace.h
fs/xfs/xfs_trace.h